Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React Native Hermes Profiling Alpha #7228

Merged
merged 12 commits into from
Jul 27, 2023
Merged

Add React Native Hermes Profiling Alpha #7228

merged 12 commits into from
Jul 27, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jun 21, 2023 •
edited
Loading

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

@vercel
Copy link

vercel bot commented Jun 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 8:29am

@krystofwoldrich krystofwoldrich mentioned this pull request Jun 21, 2023
Closed
@krystofwoldrich krystofwoldrich self-assigned this Jun 21, 2023
@shanamatthews
Copy link
Contributor

@krystofwoldrich - tag me when you're ready for a review!

@krystofwoldrich krystofwoldrich marked this pull request as ready for review June 22, 2023 09:45
@krystofwoldrich krystofwoldrich requested a review from a team as a code owner June 22, 2023 09:45
shanamatthews
shanamatthews reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a folder naming issue here. I also suggested fixes for your DSN references :)

src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
src/wizard/react-native/profiling-onboarding/go/1.install.md Outdated Show resolved Hide resolved
src/wizard/react-native/profiling-onboarding/go/3.configure-profiling.md Outdated Show resolved Hide resolved
@krystofwoldrich
Copy link
Member Author

@shanamatthews Thanks for all the notes, could you give it a second look? 🙏

lizokm
lizokm approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small copy suggestions, otherwise, LGTM

src/platforms/common/profiling/troubleshooting.mdx Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich merged commit 247bb7b into master Jul 27, 2023
6 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-rn-add-profiling branch July 27, 2023 15:52
shanamatthews added a commit that referenced this pull request Jul 31, 2023
@krystofwoldrich @shanamatthews @getsantry
Add React Native Hermes Profiling Alpha (#7228)
831e854 
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lizokm lizokm lizokm approved these changes

@shanamatthews shanamatthews shanamatthews approved these changes

@vivianyentran vivianyentran Awaiting requested review from vivianyentran

@marandaneto marandaneto Awaiting requested review from marandaneto

@kahest kahest Awaiting requested review from kahest

Assignees

@krystofwoldrich krystofwoldrich

Labels
None yet
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @shanamatthews @lizokm