Document Remix v2 support. #7320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Looking good so far! Had a couple of suggestions but once they're addressed I think we're good for now.
In general, I think it'd be worthwhile to go over this page and reduce the text/code snippets a little. But this is out of scope for this PR. I'll open an issue with some concrete suggestions to follow up on that.
src/platform-includes/getting-started-config/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-config/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-config/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Lms24
reviewed
Jul 13, 2023
src/platform-includes/getting-started-config/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
AbhiPrasad
approved these changes
Jul 17, 2023
shanamatthews
pushed a commit
that referenced
this pull request
Jul 31, 2023
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents: getsentry/sentry-javascript#8415