ref(js): Add note about react error boundary and CaptureConsole #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
3 tasks
AbhiPrasad
requested review from
a team,
stephanie-anderson and
Lms24
and removed request for
a team
Lms24
reviewed
Aug 3, 2023
| <Alert level="warning" title="Note"> | ||
|
|
||
| By default React [logs all errors to the console](https://github.com/facebook/react/blob/493f72b0a7111b601c16b8ad8bc2649d82c184a0/packages/react-reconciler/src/ReactFiberErrorLogger.js#L85), even if you are using an React error boundary. This means that Sentry will capture the error through the `CaptureConsole` integration and not through the error boundary. | ||
|
|
There was a problem hiding this comment.
reading through the issue, should we add a sentence around recommending to disable the error log level of CaptureConsole when using react?
Lms24
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/sentry-javascript#8689
Add note about interaction between react error boundary and the
CaptureConsoleintegration. This is duplicated, once in the react docs and once in theCaptureConsoledocs so that it can be discovered easily.