Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android v7 requirement API 19 #7595

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

stefanosiano
Copy link
Member

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

SDK v7 requires Android API level 19+.
This info has been added to the migration guide. Also, previous workaround for NDK on API 14 has been removed.

Extra resources

@stefanosiano stefanosiano requested a review from a team as a code owner August 4, 2023 14:56
@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 1:57pm

src/platforms/android/migration.mdx Outdated Show resolved Hide resolved
stefanosiano and others added 2 commits August 14, 2023 15:37
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@shanamatthews
Copy link
Contributor

Hey @stefanosiano - is this PR ready for merge?

@stefanosiano stefanosiano marked this pull request as draft August 23, 2023 11:32
@stefanosiano
Copy link
Member Author

Hey @stefanosiano - is this PR ready for merge?

Hey! This pr is ready to be merged by itself, as it was reviewed, but we are waiting for it.
I marked this pr with the v7 milestone: when the Android SDK v7 will be released, I'll merge this (and others waiting for the same release).
I'm converting to draft for the time being. 👍

@shanamatthews
Copy link
Contributor

Hey @stefanosiano - is this PR ready for merge?

Hey! This pr is ready to be merged by itself, as it was reviewed, but we are waiting for it. I marked this pr with the v7 milestone: when the Android SDK v7 will be released, I'll merge this (and others waiting for the same release). I'm converting to draft for the time being. 👍

Perfect, thanks!

@getsantry getsantry bot added the Stale label Oct 18, 2023
@getsantry getsantry bot closed this Oct 26, 2023
@shanamatthews shanamatthews reopened this Oct 26, 2023
@getsantry getsantry bot closed this Nov 3, 2023
@markushi markushi reopened this Nov 3, 2023
@getsantry getsantry bot closed this Nov 11, 2023
@romtsn romtsn reopened this Nov 11, 2023
@getsantry getsantry bot closed this Nov 19, 2023
@romtsn romtsn reopened this Nov 20, 2023
@romtsn romtsn removed the Stale label Nov 20, 2023
@romtsn romtsn marked this pull request as ready for review November 30, 2023 12:58
@romtsn romtsn merged commit 5f49b2b into master Nov 30, 2023
30 checks passed
@romtsn romtsn deleted the stefanosiano/android/min_api_update branch November 30, 2023 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants