Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add page for long tasks causing frame drops #7625

Merged
merged 24 commits into from
Sep 19, 2023

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Aug 11, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Add a new page for Frame Drop profiling issues.

TODO

Extra resources

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 0:22am

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a work in progress, but have made some language suggestions. Let me know when it's ready and I can look at it again :)

armcknight and others added 4 commits August 15, 2023 13:53
…task-causing-frame-drop/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…task-causing-frame-drop/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
…task-causing-frame-drop/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
Copy link
Member

@indragiek indragiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should replace the screenshot before publishing this

@armcknight
Copy link
Member Author

We should replace the screenshot before publishing this

Yup, I already have this as a TODO item in the description!

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good!

armcknight and others added 2 commits August 23, 2023 23:20
@armcknight armcknight merged commit a5bd9ca into master Sep 19, 2023
7 checks passed
@armcknight armcknight deleted the armcknight/docs/main-thread-frame-drops branch September 19, 2023 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants