Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add note about upsert endpoints #7666

Merged

Conversation

evanpurkhiser
Copy link
Member

Refs #7664

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 10:12pm

@evanpurkhiser evanpurkhiser requested a review from a team August 17, 2023 18:38
src/platforms/common/crons/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: David Wang <dwang@sentry.io>
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +132 to +133
In the future this feature will use the `ingest.sentry.io` style check in
format and the `sentry.io/api` format will be deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the future this feature will use the `ingest.sentry.io` style check in
format and the `sentry.io/api` format will be deprecated.
In the future this feature will use the `ingest.sentry.io` style check in
format. The `sentry.io/api` format will be deprecated.

@evanpurkhiser evanpurkhiser merged commit ccca590 into master Aug 28, 2023
6 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-crons-add-note-about-upsert-endpoints branch August 28, 2023 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants