chore: types improvement on Micro Frontend support document #7672
Conversation
|
@sagarhani is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
| | "replay_event" | ||
| | "replay_recording" | ||
| | "check_in"; | ||
| import { Envelope, EnvelopeItemType } from "@sentry/types"; |
There was a problem hiding this comment.
I feel it's better to move the type declaration from here to one section above. Because, when I was implementing dsnFromFeature from routing events to different projects section, I was trying to figure out what type of argument it is expecting.
What are your thoughts?
There was a problem hiding this comment.
I think it's a good idea to make that change, let's move it!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @sagarhani - did you want to go ahead and make the rest of this change to move the type declaration? |
|
Hey @shanamatthews, done! Please let know if the changes looks good to you. |
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Improve
typesupport in Micro Frontend support doc page.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources