Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple): App hanging when Watchdog termination is enabled #7681

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

brustolin
Copy link
Contributor

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Description of app hanging code running when watchdog termination is enabled was wrong.

@brustolin brustolin requested a review from a team as a code owner August 23, 2023 09:11
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 7:54am

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/platforms/apple/common/configuration/app-hangs.mdx Outdated Show resolved Hide resolved
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @shanamatthews changes :)

Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@brustolin brustolin enabled auto-merge (squash) August 28, 2023 07:45
@brustolin brustolin merged commit a593a2e into master Aug 28, 2023
7 checks passed
@brustolin brustolin deleted the fix(apple)/apphang-wording branch August 28, 2023 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants