-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Remix wizard instructions #7768
Conversation
Add remix wizard, just moving over similar to next for now.
….mdx thank you! Co-authored-by: Onur Temizkan <onur@narval.co.uk>
….mdx Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
manual-setup
.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions, but otherwise this looks great!
src/platform-includes/getting-started-config/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the suggestions are applied, thanks Onur!
}); | ||
``` | ||
|
||
## Custom Express Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: I'd prefer this section and the v2 support section to switch places unless there's a concrete reason to have custom express server instructions come first(?) My thinking is that showing that we support v2 (future flags) is more important than custom servers.
….mdx Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Liza Mock <lizka920@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only requesting changes so we don't merge this until getsentry/sentry-wizard#433 is resolved. Let's only publish this once the wizard is fully ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We released the wizard with the org/project fix yesterday so this is ready to go. Just one small suggestion but otherwise ready to 🚢
….mdx Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
}); | ||
``` | ||
|
||
Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/v1/api/conventions#action) and [`loader`](https://remix.run/docs/en/v1/api/conventions#loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these links have moved
Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/v1/api/conventions#action) and [`loader`](https://remix.run/docs/en/v1/api/conventions#loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls. | |
Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/1.19.3/route/action) and [`loader`](https://remix.run/docs/en/1.19.3/route/loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls. |
Co-authored-by: Onur Temizkan <onur@narval.co.uk>
Fixes: #7727
Continues: #7728
Can't push commits to the original PR, so opened a new one.