Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remix wizard instructions #7768

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Sep 7, 2023

Fixes: #7727
Continues: #7728

Can't push commits to the original PR, so opened a new one.

@vercel
Copy link

vercel bot commented Sep 7, 2023

@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@onurtemizkan onurtemizkan changed the title Move manual configuration instructions to manual-setup. Add Remix wizard instructions Sep 7, 2023
@Lms24 Lms24 requested review from a team, lforst, AbhiPrasad and Lms24 and removed request for a team September 7, 2023 16:56
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 0:32am

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions, but otherwise this looks great!

src/platforms/javascript/guides/remix/manual-setup.mdx Outdated Show resolved Hide resolved
src/platforms/javascript/guides/remix/manual-setup.mdx Outdated Show resolved Hide resolved
src/platforms/javascript/guides/remix/manual-setup.mdx Outdated Show resolved Hide resolved
src/platforms/javascript/guides/remix/manual-setup.mdx Outdated Show resolved Hide resolved
src/platforms/javascript/guides/remix/manual-setup.mdx Outdated Show resolved Hide resolved
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the suggestions are applied, thanks Onur!

});
```

## Custom Express Server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: I'd prefer this section and the v2 support section to switch places unless there's a concrete reason to have custom express server instructions come first(?) My thinking is that showing that we support v2 (future flags) is more important than custom servers.

onurtemizkan and others added 3 commits September 8, 2023 09:57
….mdx

Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Liza Mock <lizka920@gmail.com>
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only requesting changes so we don't merge this until getsentry/sentry-wizard#433 is resolved. Let's only publish this once the wizard is fully ready.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We released the wizard with the org/project fix yesterday so this is ready to go. Just one small suggestion but otherwise ready to 🚢

….mdx

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
});
```

Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/v1/api/conventions#action) and [`loader`](https://remix.run/docs/en/v1/api/conventions#loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these links have moved

Suggested change
Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/v1/api/conventions#action) and [`loader`](https://remix.run/docs/en/v1/api/conventions#loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls.
Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/1.19.3/route/action) and [`loader`](https://remix.run/docs/en/1.19.3/route/loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls.

Co-authored-by: Onur Temizkan <onur@narval.co.uk>
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) September 19, 2023 13:38
@AbhiPrasad AbhiPrasad merged commit ee9023c into getsentry:master Sep 19, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Remix docs to use the wizard
6 participants