Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): Change "Report a problem" link to open feedback modal #7878

Merged

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Sep 19, 2023

Changes the "Report a problem" link to open feedback modal (when Sentry SDK is loaded). Otherwise will preserve previous behavior of opening link to GH issue.

Depends on #7876

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 1:18am

@billyvg billyvg changed the base branch from master to ref-feedback-decouple-feedback-button-and-modal September 19, 2023 17:17
@billyvg billyvg changed the title ref(feedback): De-couple button from modal feat(feedback): Change "Report a problem" link to open feedback modal Sep 19, 2023
@billyvg billyvg marked this pull request as ready for review September 19, 2023 19:30
Base automatically changed from ref-feedback-decouple-feedback-button-and-modal to master September 19, 2023 22:09
@billyvg billyvg enabled auto-merge (squash) September 19, 2023 22:09
Changes the "Report a problem" link to open feedback modal (when Sentry SDK is loaded). Otherwise will preserve previous behavior of opening link to GH issue.
@billyvg billyvg merged commit c7fd4c6 into master Sep 20, 2023
7 checks passed
@billyvg billyvg deleted the feat-feedback-replace-report-a-problem-link-with-modal branch September 20, 2023 17:07
billyvg added a commit that referenced this pull request Sep 29, 2023
billyvg added a commit that referenced this pull request Sep 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants