Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Match user token update and prioritize internal integrations #7918

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

schew2381
Copy link
Member

@schew2381 schew2381 commented Sep 21, 2023

Background

As part of the change to Introduce Scope Hierarchy, I edited the page where you create user auth tokens to use the same dropdowns as internal integrations in getsentry/sentry#54651. You can test this for yourself here.

Changes

  1. Clarify that user auth tokens are not editable after they are created. In order to change the scopes on them, you must create a new token.
  2. Replace old picture of the create user auth page from box selectors to the new dropdowns
  3. I moved user auth tokens to below integration tokens to hopefully have people favor integration > user tokens. In the future, we will probably look into eventually deprecating user auth tokens in favor of the other 2 tokens.
  4. For the internal integration, I changed the wording from
    See our docs on Internal Integrations to learn more.
    to
    To get started, see our docs on Internal Integrations
    because it wasn't immediately clear to me which link in that section leads to the steps to create the integration.

@schew2381 schew2381 self-assigned this Sep 21, 2023
@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 10:42pm

@schew2381 schew2381 marked this pull request as ready for review September 21, 2023 21:34
@schew2381 schew2381 changed the title clarify some stuff, and reorder to prioritize internal integrations fix(docs): Replace create use token images and prioritize internal integrations Sep 21, 2023
@schew2381 schew2381 changed the title fix(docs): Replace create use token images and prioritize internal integrations fix(docs): Match create user token changes and prioritize internal integrations Sep 21, 2023
@schew2381 schew2381 changed the title fix(docs): Match create user token changes and prioritize internal integrations fix(docs): Match user token update and prioritize internal integrations Sep 21, 2023
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/docs/product/accounts/auth-tokens/index.mdx Outdated Show resolved Hide resolved
schew2381 and others added 2 commits September 21, 2023 15:26
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@schew2381 schew2381 merged commit 1586111 into master Sep 21, 2023
7 checks passed
@schew2381 schew2381 deleted the seiji/fix/clarify-different-tokens branch September 21, 2023 22:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants