Fix sitemap paths #9439
Merged
Fix sitemap paths #9439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getDocsFrontMatter` returns an extra `/index` at the end of some paths, which breaks the sitemap. This is already handled by its only other caller, in `app/[[..path]]/page.tsx`.
Currently the removal of a final `/index` path is duplicated in both the page and sitemap components - move it up into getDocsFrontMatter, which they both call.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lizokm reported that only some of the pages in the sitemap.xml were being indexed properly. This was caused by an extra trailing
/indexin many of the paths. This is something that the main Page component already handles, but it was missed in the sitemap. Moved this fix up a level (intogetDocsFrontMatter()) so that it didn't have to be duplicated into both the page and the sitemap, and so that future callers don't run into this same oversight.