Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add experimental module metadata injection #334

Merged
merged 7 commits into from
Jul 3, 2023
Merged

feat: Add experimental module metadata injection #334

merged 7 commits into from
Jul 3, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jun 28, 2023 •
edited
Loading

Closes #323

This PR:

  • Adds moduleMetadata to _experiments option
  • Adds an optional plugin for injecting module metadata
  • Only adds plugin when it exists and moduleMetadata has been set
  • Adds an implementation for the webpack plugin

This PR does not yet pass through entryPoint to the metadata callback as suggested here.

  • Needs tests!

@timfish timfish marked this pull request as ready for review June 29, 2023 19:07
@timfish timfish requested a review from lforst June 29, 2023 19:09
@timfish
Copy link
Collaborator Author

timfish commented Jun 29, 2023 •
edited
Loading

The newly added e2e tests pass on my machine but don't run in CI from my fork...

@lforst
Copy link
Member

lforst commented Jun 30, 2023

The newly added e2e tests pass on my machine but don't run in CI from my fork...

Ah we disabled E2E tests since we introduced debug IDs since the ones we had didn't make sense anymore.

Lemme look into this...

@timfish
Copy link
Collaborator Author

timfish commented Jun 30, 2023

we disabled E2E tests since we introduced debug IDs since the ones we had didn't make sense anymore

My assumption was that e2e tests are disabled for PRs from external forks since an auth token is used for the basic_upload test.

@lforst
Copy link
Member

lforst commented Jun 30, 2023

we disabled E2E tests since we introduced debug IDs since the ones we had didn't make sense anymore

My assumption was that e2e tests are disabled for PRs from external forks since an auth token is used for the basic_upload test.

That too!

@timfish timfish mentioned this pull request Jun 30, 2023
Merged
lforst
lforst approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! :)

@lforst lforst changed the title feat: Add module metadata injection feat: Add experimental module metadata injection Jul 3, 2023
@lforst lforst merged commit 751a0cb into getsentry:main Jul 3, 2023
16 checks passed
@timfish timfish deleted the feat/module-metadata branch July 3, 2023 14:17
This was referenced Aug 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[webpack & MFEs] Able to uniquely identified JS code associated with different teams
2 participants
@timfish @lforst