fix(opentelemetry): Do not overwrite http span name if kind is internal #27246
Annotations
10 errors
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(14) } to match object { event_id: Any<String>, …(6) }
(21 matching properties omitted from actual)
- Expected
+ Received
Object {
"event_id": Any<String>,
"request": Object {
"cookies": Any<Object>,
"headers": Object {
"host": StringContaining "localhost:",
"user-agent": Any<String>,
},
"method": "POST",
"url": "http://localhost:33877/action-json-response/123123",
},
"spans": Array [
Object {
"data": Object {
"code.function": "action",
"match.params.id": "123123",
"match.route.id": "routes/action-json-response.$id",
"sentry.op": "action.remix",
},
},
Object {
"data": Object {
"code.function": "loader",
"match.params.id": "123123",
"match.route.id": "routes/action-json-response.$id",
"sentry.op": "loader.remix",
},
},
Object {
"data": Object {
"code.function": "loader",
"match.params.id": "123123",
"match.route.id": "root",
"sentry.op": "loader.remix",
},
},
],
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:17:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(16) } to match object { event_id: Any<String>, …(6) }
(24 matching properties omitted from actual)
- Expected
+ Received
Object {
"event_id": Any<String>,
"request": Object {
"cookies": Any<Object>,
"headers": Object {
"host": StringContaining "localhost:",
"user-agent": Any<String>,
},
"method": "POST",
"url": "http://localhost:37459/action-json-response/-1",
},
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:107:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(15) } to match object { event_id: Any<String>, …(6) }
(18 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 302,
},
"op": "http.server",
"status": "ok",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:150:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(15) } to match object { event_id: Any<String>, …(6) }
(18 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 500,
},
"op": "http.server",
"status": "internal_error",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:204:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(15) } to match object { event_id: Any<String>, …(6) }
(18 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 500,
},
"op": "http.server",
"status": "internal_error",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:246:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(15) } to match object { event_id: Any<String>, …(6) }
(18 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 500,
},
"op": "http.server",
"status": "internal_error",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:288:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(15) } to match object { event_id: Any<String>, …(6) }
(18 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 500,
},
"op": "http.server",
"status": "internal_error",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST action-json-response/:id",
+ "transaction": "remix.request action-json-response/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:330:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(16) } to match object { event_id: Any<String>, …(6) }
(20 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 500,
},
"op": "http.server",
"status": "internal_error",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST server-side-unexpected-errors/:id",
+ "transaction": "remix.request server-side-unexpected-errors/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:372:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(16) } to match object { event_id: Any<String>, …(6) }
(20 matching properties omitted from actual)
- Expected
+ Received
Object {
"contexts": Object {
"trace": Object {
"data": Object {
"http.response.status_code": 500,
},
"op": "http.server",
"status": "internal_error",
},
},
"event_id": Any<String>,
"spans": Any<Array>,
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "POST server-side-unexpected-errors/:id",
+ "transaction": "remix.request server-side-unexpected-errors/:id",
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/action.test.ts:414:27
|
dev-packages/node-integration-tests/utils/index.ts#L32
AssertionError: expected { contexts: { …(8) }, …(15) } to match object { event_id: Any<String>, …(6) }
(25 matching properties omitted from actual)
- Expected
+ Received
Object {
"event_id": Any<String>,
"spans": Array [
Object {
"data": Object {
"code.function": "loader",
"sentry.op": "loader.remix",
},
"origin": "manual",
},
Object {
"data": Object {
"code.function": "loader",
"sentry.op": "loader.remix",
},
"origin": "manual",
},
],
"start_timestamp": Anything,
"timestamp": Anything,
- "transaction": "GET loader-json-response/:id",
+ "transaction": "remix.request loader-json-response/:id",
"transaction_info": Object {
- "source": "route",
+ "source": "custom",
},
"type": "transaction",
}
❯ Module.assertSentryTransaction ../../dev-packages/node-integration-tests/utils/index.ts:32:18
❯ test/integration/test/server/instrumentation-otel/loader.test.ts:82:27
|
This job failed
Loading