Skip to content

Commit

Permalink
Merge pull request #11232 from getsentry/abhi-7.107.0
Browse files Browse the repository at this point in the history
meta: CHANGELOG for 7.108.0
  • Loading branch information
AbhiPrasad authored Mar 21, 2024
2 parents bf4ea76 + 4f5d487 commit 238c460
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 9 deletions.
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,25 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 7.108.0

This release fixes issues with Time to First Byte (TTFB) calculation in the SDK that was introduced with `7.95.0`. It
also fixes some bugs with Interaction to First Paint (INP) instrumentation. This may impact your Sentry Performance
Score calculation.

- feat(serverless): Add Node.js 20 to compatible runtimes (#11104)
- feat(core): Backport `ResizeObserver` and `googletag` default filters (#11210)
- feat(webvitals): Adds event entry names for INP handler. Also guard against empty metric value
- fix(metrics): use correct statsd data category (#11187)
- fix(node): Record local variables with falsy values (v7) (#11190)
- fix(node): Use unique variable for ANR context transfer (v7) (#11162)
- fix(node): Time zone handling for `cron` (#11225)
- fix(tracing): use web-vitals ttfb calculation (#11231)
- fix(types): Fix incorrect `sampled` type on `Transaction` (#11146)
- fix(webvitals): Fix mapping not being maintained properly and sometimes not sending INP spans (#11183)

Work in this release contributed by @quisido and @joshkel. Thank you for your contributions!

## 7.107.0

This release fixes issues with INP instrumentation with the Next.js SDK and adds support for the `enableInp` option in
Expand Down
4 changes: 2 additions & 2 deletions packages/node/src/cron/cron.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export function instrumentCron<T>(lib: T & CronJobConstructor, monitorSlug: stri
},
{
schedule: { type: 'crontab', value: cronString },
...(timeZone ? { timeZone } : {}),
timezone: timeZone || undefined,
},
);
}
Expand Down Expand Up @@ -132,7 +132,7 @@ export function instrumentCron<T>(lib: T & CronJobConstructor, monitorSlug: stri
},
{
schedule: { type: 'crontab', value: cronString },
...(timeZone ? { timeZone } : {}),
timezone: timeZone || undefined,
},
);
};
Expand Down
21 changes: 14 additions & 7 deletions packages/node/test/cron.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,20 @@ describe('cron check-ins', () => {

const CronJobWithCheckIn = cron.instrumentCron(CronJobMock, 'my-cron-job');

new CronJobWithCheckIn('* * * Jan,Sep Sun', () => {
expect(withMonitorSpy).toHaveBeenCalledTimes(1);
expect(withMonitorSpy).toHaveBeenLastCalledWith('my-cron-job', expect.anything(), {
schedule: { type: 'crontab', value: '* * * 1,9 0' },
});
done();
});
new CronJobWithCheckIn(
'* * * Jan,Sep Sun',
() => {
expect(withMonitorSpy).toHaveBeenCalledTimes(1);
expect(withMonitorSpy).toHaveBeenLastCalledWith('my-cron-job', expect.anything(), {
schedule: { type: 'crontab', value: '* * * 1,9 0' },
timezone: 'America/Los_Angeles',
});
done();
},
undefined,
true,
'America/Los_Angeles',
);
});

test('CronJob.from()', done => {
Expand Down

0 comments on commit 238c460

Please sign in to comment.