test(e2e): Fix types

At least locally I got some type errors here, let's see...
getsentry · Jul 11, 2023 · 83a8e42 · 83a8e42
1 parent 704b846
commit 83a8e42
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/packages/e2e-tests/lib/types.ts b/packages/e2e-tests/lib/types.ts
@@ -47,4 +47,4 @@ export interface RecipeTestResult extends RecipeInstance {
   tests: TestResult[];
 }
 
-export type Env = Record<string, string | string>;
+export type Env = Record<string, string | undefined>;
diff --git a/packages/e2e-tests/lib/utils.ts b/packages/e2e-tests/lib/utils.ts
@@ -17,13 +17,14 @@ interface SpawnAsync {
   status: number | null;
 }
 
-export function spawnAsync(
-  cmd: string,
-  options?:
-    | childProcess.SpawnOptionsWithoutStdio
-    | childProcess.SpawnOptionsWithStdioTuple<childProcess.StdioPipe, childProcess.StdioPipe, childProcess.StdioPipe>,
-  input?: string,
-): Promise<SpawnAsync> {
+interface SpawnOptions {
+  timeout?: number;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  env?: any;
+  cwd?: string;
+}
+
+export function spawnAsync(cmd: string, options?: SpawnOptions, input?: string): Promise<SpawnAsync> {
   const start = Date.now();
 
   return new Promise<SpawnAsync>(resolve => {

diff --git a/packages/e2e-tests/package.json b/packages/e2e-tests/package.json
@@ -10,9 +10,10 @@
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
     "fix:prettier": "prettier --config ../../.prettierrc.json --write . ",
-    "lint": "run-s lint:prettier lint:eslint",
+    "lint": "run-s lint:prettier lint:eslint lint:ts",
     "lint:eslint": "eslint . --format stylish",
     "lint:prettier": "prettier --config ../../.prettierrc.json --check .",
+    "lint:ts": "tsc --noEmit",
     "test:e2e": "run-s test:validate-configuration test:validate-test-app-setups test:run",
     "test:run": "ts-node run.ts",
     "test:validate-configuration": "ts-node validate-verdaccio-configuration.ts",

diff --git a/packages/e2e-tests/tsconfig.json b/packages/e2e-tests/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "extends": "../../tsconfig.json",
+  "exclude": ["node_modules", "test-applications"],
   "compilerOptions": {
     "types": ["node"]
   }