Skip to content

Commit

Permalink
fix(replay): Mark ui.slowClickDetected clickCount as optional (#8376)
Browse files Browse the repository at this point in the history
This field was added as part of v7.56.0, but `SlowClickFrameData` was
created before that. Having `clickCount` be required breaks backwards
compatibility, it should be optional.
  • Loading branch information
ryan953 authored Jun 21, 2023
1 parent 4fb043e commit da2487e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/replay/src/types/replayFrame.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ interface SlowClickFrameData extends ClickFrameData {
route?: string;
timeAfterClickMs: number;
endReason: string;
clickCount: number;
clickCount?: number;
}
export interface SlowClickFrame extends BaseBreadcrumbFrame {
category: 'ui.slowClickDetected';
Expand Down

0 comments on commit da2487e

Please sign in to comment.