-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.14.0 #12749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional Changes: - Updating the versions to more recent ones. - Adding `@sentry/solid` --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
[Gitflow] Merge master into develop
…2648) Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
ref: #12644 We don't use `es-check` anymore, we can remove it. It was previously used to validate our es5 builds, but we don't target that anymore. Extracted from the previous PR because 1 big change was breaking CI and I couldn't figure out the root cause.
Currently the only way to disable ESM loader hook registration is to set: ```ts globalThis._sentryEsmLoaderHookRegistered = true; ``` After this PR, you can set the new `registerEsmLoaderHooks` option to `false`: ```ts import * as Sentry from '@sentry/node'; Sentry.init({ dsn: '__DSN__', registerEsmLoaderHooks: false, }); ``` --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
ref: #12644 We can remove `replace-in-file` with some built-in functions and clean up our lockfile even more. Extracted from the previous PR because 1 big change was breaking CI and I couldn't figure out the root cause.
This adds an E2E app using a custom OTEL setup with `@opentelemetry/sdk-node`. It tests that data is sent both to sentry as well as to another OTLP exporter. For this, I adjusted the event proxy code to also allow to spin up a generic event proxy server (which I use for the OTLP exporter). I also rewrote this to use fetch as this is a bit easier to read IMHO. This is a decent first step, we should add at least 2 more E2E test apps IMHO related to OTEL: 1. An app using `@opentelemetry/sdk-trace-node` and some more custom tracing setup (e.g. more instrumentation, custom sampler, ....) 2. An app using `@opentelemetry/sdk-trace-node` that does not use Sentry for performance at all, but only for errors, and only uses OTEL for trace monitoring. Part of #12494
To be able to differentiate between a browser/client execution context, sentry is initialized in an external config file. An import statement in `nuxt-root.vue` is added which loads this config file. Nuxt tracking issue: #9095 --------- Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Not sure how this worked before, but there was a bunch of stuff that conflicted with `noUncheckedIndexedAccess` 🤔 Noticed this locally when running browser integration tests now.
Small change filtering expected errors from being reported to sentry in the nestjs sdk. Tested manually on my sample app. Fixes #12523
This should fix the old behavior... previously, we made a PR against a PR branch when we detected that it was opened by an external contributor. This is problematic, turns out, because external contributors will usually have a fork of the repo and thus the action will fail. Now, instead, we will make a PR against develop when a contributor PR is _merged_. See example PR: #12728
https://github.com/mysticatea/npm-run-all is no longer maintained, so switching to npm-run-all2. Eliminates some deps from `yarn.lock` and should be faster!
Bumps [@prisma/instrumentation](https://github.com/prisma/prisma/tree/HEAD/packages/instrumentation) from 5.16.0 to 5.16.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prisma/prisma/releases"><code>@prisma/instrumentation</code>'s releases</a>.</em></p> <blockquote> <h2>5.16.1</h2> <p>Today, we are issuing the 5.16.1 patch release to fix an issue in Prisma client.</p> <h2>Fix in Prisma Client</h2> <ul> <li><a href="https://redirect.github.com/prisma/prisma/issues/24634">dotenv loading issue with PrismaClient </a></li> <li><a href="https://redirect.github.com/prisma/prisma/issues/24658">Prisma Seed Script Fails After Upgrading to v5.16.0 (DATABASE_URL Error)</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/prisma/prisma/commits/5.16.1/packages/instrumentation">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@prisma/instrumentation&package-manager=npm_and_yarn&previous-version=5.16.0&new-version=5.16.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once CI passes on it, as requested by @AbhiPrasad. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM. This lead to the instrumentations not running/detecting properly.
Bumps [oven-sh/setup-bun](https://github.com/oven-sh/setup-bun) from 1 to 2. - [Release notes](https://github.com/oven-sh/setup-bun/releases) - [Commits](oven-sh/setup-bun@v1...v2) --- updated-dependencies: - dependency-name: oven-sh/setup-bun dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This is just used internally, but we may as well be up to date there.
When users want to use a custom sampler, they can use these new helpers to still have sentry working nicely with whatever they decide to do in there. For e.g. trace propagation etc. to work correctly with Sentry, we need to attach some things to trace state etc. These helpers encapsulate this for the user, while still allowing them to decide however they want if the span should be sampled or not. This was brought up here: #12191 (reply in thread)
lforst
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.