meta(changelog): Update changelog for 8.15.0 #12777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
[Gitflow] Merge master into develop
This commit updates the return signature of the client's `on` function to be a void function, which, when executed, unregisters a callback. This adjustment is necessary for managing instances where objects are created and destroyed, ensuring that callbacks are properly unregistered to prevent self-referencing in callback closures and facilitate proper garbage collection. Typically, changing a type from `void` to `() => void` (or `VoidFunction`) shouldn't be considered a breaking change because `void` signifies the absence of a return value, implying that the return value of the `on` function should never be used by consumers. Opting for the `on` approach, which returns a cleanup function, "seems" simpler because having another function called `off` requires saving the callback reference for later removal. With our pattern, we encapsulate both the registration and removal of event listeners within a single function call. --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
We already report a client report for dropped standalone spans. However, so far we did not report any for spans dropped for transactions. This PR also emits a client report when `beforeSendSpan` is used to filter a span of a transaction, as well as when the whole transaction is dropped in `beforeSendTransaction`. For now, we _do not_ emit this if users manually drop single spans in e.g. `beforeSendTransaction`, which I'd say is OK for now. Closes #12727
This gets rid of the Ember canary tests that are always failing, probably due to ember-try (which we use there) not playing nicely with the monorepo etc. Instead, this now uses the proper E2E setup. I added two tests, for classic ember and modern embroider-based ember. While doing this I also noticed two bugs I fixed along the way :O This also removed the ember canary tests, IMHO the e2e tests are good enough for us there now.
First, this means it is easier to run this locally. Secondly, we do not even need to send data to Sentry anymore, so we can adjust the proxy server to stop doing this. Lastly, this means that we can also safely run E2E tests for external contributors. Closes #11910
If errors are handled with Boom inside `onPreResponse`, the error should not be reported to Sentry. fixes #12702
`getStack()` is a leftover from the Hub API and was removed with v8. The method does not need to be public anymore and therefore deleted.
…ter (#12699) Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
This failed (again) here: https://github.com/getsentry/sentry-javascript/actions/runs/9791997167/job/27036907594 Hopefully this fixes it...
In #12700 I adjusted the prepack script to bring back the build directory, but I forgot to adjust `npm pack X` to make sure we pack the tarball from the `build` directory. This patch fixes that.
Just to align stuff properly everywhere!
In our case the referrer is not passed to the feedback script and thus results in a 403 (because we set allowed domains in our project settings). Consequently also the modal doesn't open and it's a bit disappointing for us since we would like to use the feature.
mydea
reviewed
Jul 5, 2024
CHANGELOG.md
Outdated
| - fix(tracing): Report dropped spans for transactions (#12751) | ||
| - ref(scope): Delete unused public `getStack()` (#12737) | ||
|
|
||
| Work in this release was contributed by @arturovt and @jaulz. Thank you for your contribution! |
There was a problem hiding this comment.
Suggested change
| Work in this release was contributed by @arturovt and @jaulz. Thank you for your contribution! | |
| Work in this release was contributed by @arturovt and @jaulz. Thank you for your contributions! |
mydea
approved these changes
Jul 5, 2024
andreiborza
force-pushed
the
prepare-release/8.15.0
branch
from
9b05bff
to
9561fd7
Compare
andreiborza
force-pushed
the
prepare-release/8.15.0
branch
from
9561fd7
to
1af7d0a
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.