chore(e2e): Add react-17 e2e test app #12778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
approved these changes
Jul 5, 2024
Lms24
reviewed
Jul 5, 2024
There was a problem hiding this comment.
l: do we need this type anywhere? I didn't see usages of these properties (but might have missed something)
There was a problem hiding this comment.
Good catch, not needed! Removed it.
Lms24
approved these changes
Jul 5, 2024
|
(I'm a bit out of the loop - would you mind adding a sentence to the PR description what motivates adding this e2e test app? thx!) |
Yep, added. |
mydea
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a react 17 test app so we can hopefully catch breaking react 17, as we did recently (#12608) with #12204 and #12740.