meta(changelog): Update changelog for 8.16.0 #12831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
Another day, another try to fix this! Now it failed like this https://github.com/getsentry/sentry-javascript/actions/runs/9804811101/job/27073251966, hopefully this change fixes this... we'll see!
…#12761) Today, it is not (easily) possible to use custom config for the OTEL HttpInstrumentation. We depend on our own integration for various things, so overwriting this will lead to lots of problems. With this PR, you can now pass some config through directly, in an "allowlisted" way, + there is an escape hatch to add arbitrary other config: ```js Sentry.init({ integrations: [ Sentry.httpIntegration({ instrumentation: { // these three are "vetted" requestHook: (span, req) => span.setAttribute('custom', req.method), responseHook: (span, res) => span.setAttribute('custom', res.method), applyCustomAttributesOnSpan: (span, req, res) => span.setAttribute('custom', req.method), // escape hatch: Can add arbitrary other config that is passed through _experimentalConfig: { serverName: 'xxx' } }) ] }); ``` Closes #12672
… compatibility changes in dependencies (#12793) This PR fixes our broken Remix v1 @ Node 16 integration test. Over the weekend, the following transitive dependencies received minor and patch releases which removed support for EOL Node versions. - `glob` (isaacs/node-glob#596) - `lru-cache` (isaacs/node-lru-cache#340) - `jackspeack` (isaacs/jackspeak#13) IMO this, despite the dropped versions being EOL, is a breaking change and a major inconvenience for a lot of users. I added comments/opened issues with the request to revert the Node version drops and do it in a major version instead. We're by far not the only affected ones. As our tests show, at least everyone using Remix@1 on Node 16 will be broken by this. To fix, I added dependency resolutions, mostly scoped to specific packages that depend on one of the three packages. Global overrides for `glob` and `lru-cache` did not work because we have multiple dependencies depending on different major versions of said packages.
Enable running E2E tests on PRs opened from forked repositories. Previously we excluded these because some E2E tests required secrets which are not available in the forks, causing e2e test runs to always fail. Now that we separated these tests from the e2e tests that don't require secrets (#12259) we should be good to re-enable the required e2e tests for external PRs.
I noticed this after #12784, but the `<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function. So of course it wasn't getting access to the `h` ref that is passed in. That variable is what the `<div>` gets transpiled into -> it becomes `h.createElement('div')`. So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so we can pass `h` in and hopefully not have the extra `import .. from 'preact';` in the 2nd bundle. Related to #12535
This is more a safety thing that we do not swallow this accidentally in the future, that I noticed while looking through stuff.
Implements the changes from https://github.com/getsentry/sentry/compare/fn/loader-v8?expand=1 Part of #12187
I noticed that we were not actually enabling auto session tracking correctly in node, because we did not check on the correct `options` object 😬
lforst
requested review from
mydea,
Lms24,
AbhiPrasad,
nicohrubec,
s1gr1d and
andreiborza
lforst
force-pushed
the
prepare-release/8.16.0
branch
from
9dfdcc0
to
0c79440
Compare
s1gr1d
reviewed
Jul 9, 2024
Lms24
approved these changes
Jul 9, 2024
This does two things: 1. Pass the author association to the step - we do not use it right now, but it will be logged at least, allowing us to debug this. 2. Include a reference to the merged PR in the PR body.
Reports errors thrown in nitro. Tests will be added when adding the E2E test application. closes #12795
lforst
force-pushed
the
prepare-release/8.16.0
branch
from
0c79440
to
c4e3e13
Compare
Preparing `@sentry/nuxt` for a release (experimental) Merge after this PR: #12796
lforst
force-pushed
the
prepare-release/8.16.0
branch
from
c4e3e13
to
9494194
Compare
lforst
force-pushed
the
prepare-release/8.16.0
branch
from
9494194
to
d9c6dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.