Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Update CHANGELOG for 8.21.0 #13110

Merged
merged 9 commits into from
Jul 30, 2024
Merged

meta: Update CHANGELOG for 8.21.0 #13110

merged 9 commits into from
Jul 30, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 30, 2024

Second try! This PR just updates the already existing 8.21.0 entry from a previous release attempt. This didn't work but we could retract everything in time and didn't publish anything yet. So starting the release under the same version should work 🤞

andreiborza and others added 9 commits July 30, 2024 14:56
Can be used like this:

```js
const getUserData = async () => {
  'use server';
  return await withServerActionInstrumentation('getData', () => {
    return { prefecture: 'Kanagawa' };
  });
};
```

Can also be used for api routes like this:

```js
export async function GET() {
    return await withServerActionInstrumentation('getUser', () => {
        return json({ prefecture: 'Akita' })
    })
}
```
As per https://vitest.dev/config/#globals

> By default, vitest does not provide global APIs for explicitness

I think we should follow vitest defaults here and explicitly import in
the APIs that we need. This refactors our Astro SDK tests to do so.

I also went ahead and fixed up some TS errors in some tests.

This change also removes `environment: 'jsdom'` from the vite config as
it seems nothing needs this for astro. This should means that our tests
are not polluted with jsdom globals, and that future writers have to
explicitly opt-in to the behaviour.
Adds middleware instrumentation to the `@sentry/nestjs`. The
implementation lives in `@sentry/node` so that both users using
`@sentry/nestjs` directly as well as users still on `@sentry/node`
benefit. The instrumentation is automatic without requiring any
additional setup. The idea is to hook into the Injectable decorator
(every class middleware is annotated with `@Injectable` and patch the
`use` method if it is implemented.

Caveat: This implementation only works for class middleware, which
implements the `use` method, which seems to be the standard for
implementing middleware in nest. However, nest also provides functional
middleware, for which this implementation does not work.
…tion test setup (#13108)

- Add symlinks to lazy-loaded feedback sub-integrations whenever we discover that `feedbackIntegration` is
imported in a test app
- Stop forwarding the CDN bundle request to the actual CDN but throw a
hard error instead
@Lms24 Lms24 requested review from a team, lforst and s1gr1d and removed request for a team July 30, 2024 15:02
@Lms24 Lms24 self-assigned this Jul 30, 2024
@Lms24 Lms24 changed the base branch from develop to master July 30, 2024 15:13
@Lms24 Lms24 merged commit dd3b1aa into master Jul 30, 2024
30 checks passed
@Lms24 Lms24 deleted the prepare-release/8.21.0 branch July 30, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants