feat(node): Add shouldHandleError option to fastify error handler #13198
Conversation
AbhiPrasad
added
the
Integration: fastify
| const shouldHandleError = options?.shouldHandleError || defaultShouldHandleError; | ||
|
|
||
| fastify.addHook('onError', async (request, reply, error) => { |
There was a problem hiding this comment.
I think, since digging into this more, that my initial suggestion was incomplete - reply.status is probably going to be 200 here, and instead there is, I think, error.statusCode, according to the fastify-sentry plugin? https://github.com/immobiliare/fastify-sentry/blob/main/lib/base.js#L43-L46
There was a problem hiding this comment.
This is not a fastify-sentry plugin, but an immobiliare plugin for fastify. Not official.
Reply and Error are not the same since the reply could have been sent before the error occurred.
| * @param error Captured middleware error | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| shouldHandleError?(this: void, request: any, reply: any, error: Error): boolean; |
There was a problem hiding this comment.
It is better to use explicit types instead of any
import type { FastifyRequest, FastifyReply } from 'fastify';
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| function defaultShouldHandleError(_request: any, reply: any, _error: Error): boolean { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| return reply.statusCode >= 500; |
There was a problem hiding this comment.
statusCode can be undefined
There was a problem hiding this comment.
// eslint-disable-next-line is used everywhere, it is not clear why you need eslint in the project then.
resolves #13197
Aligns fastify error handler with the express one.
shouldHandleErrorto allow users to configure if errors should be capturedshouldHandleErroronly captures errors for 5xx status codes.