Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add tedious integration #13486

Merged
merged 12 commits into from
Nov 7, 2024
Merged

feat(node): Add tedious integration #13486

merged 12 commits into from
Nov 7, 2024

Conversation

Zen-cronic
Copy link
Contributor

Resolves #13316

Implement Tedious OTL instrumentation in packages/node.

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@Zen-cronic
feat(node): Add tedious instrumentation as a node integration
56f6756 
Implement otel tedious instrumentation.
Add e2e test in 'node-integration-tests'.

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic
test(node): Update test for tedious integration
b57701f 
Add docker-compose file for setting up mssql.
Update test assertions to check for semantic attributes and origin.

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
Zen-cronic
Zen-cronic commented Aug 27, 2024
View reviewed changes
dev-packages/node-integration-tests/suites/tracing/tedious/docker-compose.yml
- '1433:1433'
environment:
ACCEPT_EULA: 'Y'
MSSQL_SA_PASSWORD: 'TESTing123'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password must pass this criteria.

@Zen-cronic
chore(node): Update tedious package to latest
fdf570c 
Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@lforst lforst self-requested a review August 28, 2024 11:42
@Zen-cronic
fix(node): Change dependencies versions for compatibility
f5ea992 
Downgrade 'tedious' to '15.1.3' to support node 14, 16, and 18.
Bump '@opentelemetry/instrumentation-tedious' to '0.13.0'.

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic
fix(node): Fix formatting
5e5fddc 
Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic
fix(e2e): Update exports for node-exports-test-app
8322347 
Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic
chore(node): Add exports in more sdk packages
cd5a664 
Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic Zen-cronic changed the title feat(node): Add tedious instrumentation as a node integration feat(node): Add tedious integration Aug 30, 2024
@Zen-cronic
Copy link
Contributor Author

The check Node (22) (TS 3.8) Integration Tests is a consistent fail - observed in previous commits as well.

This is b/c:

  • tedious 15.1.3 is the newest version that supports node >= 14.
  • That version of tedious depends on @azure/identity 2.1.0.
  • Which in turn depends on @azure/msal-node 1.18.4. This (deprecated) package doesn't support node 22, causing the failed check.

We could bump tedious to 16.x.x or later, but those versions lacks support for node 14 and/or 16.

@lforst
Copy link
Member

lforst commented Sep 2, 2024

We could bump tedious to 16.x.x or later, but those versions lacks support for node 14 and/or 16.

I recommend we add support for a newer version that may not be supporting as many older node versions!

@Zen-cronic
Copy link
Contributor Author

I recommend we add support for a newer version that may not be supporting as many older node versions!

Noted! I'll look into it then.

@mydea mydea added the Package: node Issues related to the Sentry Node SDK label Sep 13, 2024
@Zen-cronic
chore(e2e): Bump tedious version to support latest node versions
6ed801c 
Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
@Zen-cronic
Copy link
Contributor Author

I recommend we add support for a newer version that may not be supporting as many older node versions!

Noted! I'll look into it then.

Bumped to 18.6.1, which supports node >=18.

@AbhiPrasad
Copy link
Member

Hey @Zen-cronic, apologies for the delay in reviewing this! I'd like to help push this forward so I'm going to push some commits to this branch to resolve conflicts and get it up to date.

@AbhiPrasad AbhiPrasad self-assigned this Nov 6, 2024
@Zen-cronic
Copy link
Contributor Author

awesome!

@AbhiPrasad AbhiPrasad merged commit 8c2aa1b into getsentry:develop Nov 7, 2024
130 of 131 checks passed
@HazAT HazAT mentioned this pull request Nov 7, 2024
Merged
lforst pushed a commit that referenced this pull request Nov 11, 2024
@HazAT
ref: Add external contributor to CHANGELOG.md (#14206)
23c4ad1 
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@AbhiPrasad AbhiPrasad

Labels
Package: node Issues related to the Sentry Node SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tediousIntegration to Node
4 participants
@Zen-cronic @lforst @AbhiPrasad @mydea