Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Add PR link to changelog entry #13735

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Sep 20, 2024

Adds the PR link to the changelog for easier access.

An entry would look like this:

  • feat(node): Add dataloader integration (#13664)
- feat(node): Add `dataloader` integration ([#13664](https://github.com/getsentry/sentry-javascript/pull/13664))

@s1gr1d s1gr1d requested review from a team, mydea and Lms24 and removed request for a team September 20, 2024 07:56
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to add the link a while ago but stopped because GH is smart enough to infer the link in the release entries. What's the motivation for bringing this back?

Not opposed to the change, just asking :)

Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.52 KB - -
@sentry/browser - with treeshaking flags 21.3 KB - -
@sentry/browser (incl. Tracing) 34.8 KB - -
@sentry/browser (incl. Tracing, Replay) 71.3 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.75 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.64 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.43 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.28 KB - -
@sentry/browser (incl. metrics) 26.83 KB - -
@sentry/browser (incl. Feedback) 39.66 KB - -
@sentry/browser (incl. sendFeedback) 27.19 KB - -
@sentry/browser (incl. FeedbackAsync) 31.96 KB - -
@sentry/react 25.28 KB - -
@sentry/react (incl. Tracing) 37.77 KB - -
@sentry/vue 26.72 KB - -
@sentry/vue (incl. Tracing) 36.67 KB - -
@sentry/svelte 22.66 KB - -
CDN Bundle 23.83 KB - -
CDN Bundle (incl. Tracing) 36.56 KB - -
CDN Bundle (incl. Tracing, Replay) 71.06 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.38 KB - -
CDN Bundle - uncompressed 69.81 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.44 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.31 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.53 KB - -
@sentry/nextjs (client) 37.73 KB +0.54% +206 B 🔺
@sentry/sveltekit (client) 35.37 KB - -
@sentry/node 121.77 KB - -
@sentry/node - without tracing 93.41 KB - -
@sentry/aws-serverless 103.11 KB - -

View base workflow run

@s1gr1d
Copy link
Member Author

s1gr1d commented Sep 20, 2024

Maybe GitHub deleted this feature but I don't see them linked 👀 That's why I wanted to add this
https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md

Edit: Just saw that GitHub links the PRs, but only in the releases: https://github.com/getsentry/sentry-javascript/releases

@s1gr1d s1gr1d merged commit dbfd8e2 into develop Sep 20, 2024
105 checks passed
@s1gr1d s1gr1d deleted the sig/changelog-with-links branch September 20, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants