perf(opentelemetry): Bucket spans for cleanup #14154
Open
+133
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
mydea
reviewed
Nov 13, 2024
mydea
reviewed
Nov 13, 2024
| } | ||
|
|
||
| /** Try to flush any pending spans immediately. */ | ||
| public flush(): void { | ||
| this._clearTimeout(); | ||
|
|
||
| const openSpanCount = this._finishedSpans.length; | ||
| const finishedSpans: ReadableSpan[] = []; | ||
| this._finishedSpanBuckets.forEach(bucket => { |
There was a problem hiding this comment.
l: Can we instead add a get _finishSpans(): ReadableSpan[] getter on the exporter class and use this? This makes it easier to test this as well as we can just access this in tests too? 🤔
mydea
reviewed
Nov 13, 2024
| public constructor(options?: { timeout?: number }) { | ||
| this._finishedSpans = []; | ||
| this._timeout = options?.timeout || DEFAULT_TIMEOUT; | ||
| private _finishedSpanBuckets: (FinishedSpanBucket | undefined)[]; |
There was a problem hiding this comment.
l: Could we add comments to these explaining what they do here, e.g. why do we keep the spansToBucketEntry etc? it all makes sense to me, but for the sake of our future selves :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn lint) & (yarn test).We had a huge performance problem with a overhead of 5x or so in CPU Load. We investigated the issue and saw that the cleanup logic for OTEL ran on every span end. Thats why we rewrote this to run only once every interval.
I do not guarantee that this code is perfect, this is just a hint, that there is something wrong currently.