ref(profiling) Fix Electron support #14215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/profiling/electron-binaries
branch
from
d039d8b
to
154c42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes electron crash described in #13978 (reply in thread)
I've decided not to provide any precompiled binaries yet, in part because I need more time, and also because I'm also not sure if that is something we want to do. Reading electron native module docs, it seems that the recommended approach in electron is to use electron/rebuild package to rebuild dependencies, which defeats the purpose of us providing precompiled binaries.
For now, this fixes the crash and allows users to at least use the package and we can reevaluate with time if the prebuilt binaries are something we want to add.