Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling) test local require #14470

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 25, 2024

Fixes our CJS detection by no longer storing a reference to require on globalThis.

E2E test currently fails as the installed package does not reflect the changes from this PR (help appreciated)

Fixes #14525, #13662

@JonasBa JonasBa force-pushed the jb/profiling/local-require branch 2 times, most recently from f2ef50c to 5f6dba9 Compare November 30, 2024 14:20
@JonasBa JonasBa force-pushed the jb/profiling/local-require branch 2 times, most recently from a45f224 to 32633bf Compare December 2, 2024 21:55
@JonasBa JonasBa marked this pull request as ready for review December 3, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[express] express auto instrumentation no longer works if you enable profiling
1 participant