fix(core): Decode filename and module stack frame properties in Node stack parser
#14544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-core-node-stack-parser-decode-filename
branch
from
a4ee349 to
73eda05
Compare
Lms24
changed the title
filename and module stack frame properties in Node stack parser
Lms24
commented
Dec 3, 2024
There was a problem hiding this comment.
the module name extraction logic was previously untested. Thought I'd add some general tests as well.
Comment on lines
+49
to
+50
| const moduleName = dir.slice(normalizedBase.length + 1).replace(/\//g, '.'); | ||
| return moduleName ? `${moduleName}:${decodedFile}` : decodedFile; |
There was a problem hiding this comment.
This change also includes a tiny refactor to use a template string instead of concatenation. I made the change after writing the tests btw, so this should be fine
AbhiPrasad
approved these changes
Dec 3, 2024
Lms24
force-pushed
the
lms/fix-core-node-stack-parser-decode-filename
branch
from
37d1091 to
681b591
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #14525, I noticed that for some reason, I wasn't getting any context lines for the source JS file but instead a bunch of debug messages about the SDK not being able to read the file. The file path happened to contain spaces which were URL-encoded (
%20). It turns out that in ESM, the Node stack trace filenames are URL-encoded. I checked and this and it only seems to be the case in ESM, not in CJS.Specifically, this PR:
filenamestack frame propertymoduleproperty (which is derived from the raw filename)