Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(replay): skip captures multiple multi clicks on firefox and webkit #8514

Merged
merged 1 commit into from
Jul 12, 2023
Merged

test(replay): skip captures multiple multi clicks on firefox and webkit #8514

merged 1 commit into from
Jul 12, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad changed the title test(replay): skip captures multiple multi clicks on firefox test(replay): skip captures multiple multi clicks on firefox and webkit Jul 12, 2023
@AbhiPrasad AbhiPrasad requested review from billyvg and mydea July 12, 2023 15:40
billyvg
billyvg approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:|

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.58 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.16 KB (+0.07% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.51 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.82 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad mentioned this pull request Jul 12, 2023
Closed
5 tasks
@AbhiPrasad AbhiPrasad merged commit 6be123e into develop Jul 12, 2023
51 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-skip-flaky-relay-test branch July 12, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: [webkit] › suites/replay/slowClick/mutation/test.ts:67:11 › multiple clicks are counted
3 participants
@AbhiPrasad @billyvg @Lms24