feat(tracing): Add more network timings to http calls #8540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are enough now that we'll have to hide some in the UI, but we should be collecting all of these so we can better determine reasons for initial request delay.
k-fish
requested review from
a team,
lforst and
AbhiPrasad
and removed request for
a team
size-limit report 📦
|
mydea
reviewed
Jul 17, 2023
| ['http.request.fetch_start', resourceTiming.fetchStart], | ||
| ['http.request.domain_lookup_start', resourceTiming.domainLookupStart], | ||
| ['http.request.domain_lookup_end', resourceTiming.domainLookupEnd], | ||
| ['http.request.connect_start', resourceTiming.connectStart], |
There was a problem hiding this comment.
Just to be clear, is it on purpose that we changed this from:
(browserPerformanceTimeOrigin + resourceTiming.connectStart) / 1000to just
resourceTiming.connectStart?
There was a problem hiding this comment.
I did intentionally do that, but I'm still trying to figure whether it makes more sense to align against browserTimingOrigin or just record the the values as is and change the representation internally. Mostly since I've seen these reported values be less than the wrapping span startTime so something isn't adding up.
There was a problem hiding this comment.
Actually after thinking about it some more, I'm changing it back. Absolute time makes the most sense I think it's up to the sdk to provide time normalized against span start/end time not a representation concern.
…tsentry/sentry-javascript into feat/tracing-add-more-network-timings
AbhiPrasad
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are enough now that we'll have to hide some in the UI, but we should be collecting all of these so we can better determine reasons for initial request delay.