Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Truncate aggregate exception values (LinkedErrors) #8593

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 19, 2023

As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.

closes #8580

@Lms24 Lms24 requested review from kamilogorek and mydea July 19, 2023 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified) 71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.88 KB (+0.08% 🔺)

@Lms24 Lms24 merged commit 7d7b8ad into develop Jul 21, 2023
@Lms24 Lms24 deleted the lms/fix-linkederrors-message-truncation branch July 21, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors
2 participants