-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): Add route handler instrumentation #8832
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does this get react server components working as well?
I wonder if we can attach react server component payloads for debugging and having some fancy parsing for them in the Sentry UI
RSCs have been working since a very long time |
I was under the impression that automatic instrumentation didn't work - do you have example transactions to look at? |
I'm a dummy - of course I helped review these PRs as well Then we should try to see if we can RSC payload into those transaction events. |
I don't understand what you mean by RSC payload. It's just a messed up version of HTML that is returned. Are we tracking response contents in other places too? Also, this PR has nothing to do with RSCs. This is just adding instrumentation for the app router's version of API routes. |
RSC stuff was a complete aside - I misunderstood the scope of this PR. I'd imagine this working like how the new GraphQL stuff works as per getsentry/sentry#50230. There has been value in this, see https://rsc-parser.vercel.app/ |
…formance' into lforst-app-router-route-handler
Thanks @lforst and colleagues – been looking forward to this for a while! |
packages/e2e-tests/test-applications/nextjs-app-dir/sentry.edge.config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @lforst ! Is this fix already included in v7.66 or still is yet to be included in an upcoming release? |
@edgarlr it'll be out with the next release! |
I tried the beta version and got this issue: #8934, but the capturing seemed to work. |
Fixed for above issue was released in 7.67.0! |
Resolves #7228
Adds support for route handlers by:
This does not yet properly implement
RequestData
metadata. We will do this in a follow-up.