Skip to content

Commit

Permalink
feat: Add retention values to DLQ (#228)
Browse files Browse the repository at this point in the history
DLQ retention is one week. This matches what we do across all DLQ topics in Sentry prod.
  • Loading branch information
lynnagara authored Mar 6, 2024
1 parent 5d7ff5d commit 266f25e
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion python/tests/test_sentry_kafka_schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def test_get_topic() -> None:
assert topic_data["topic_creation_config"] == {"max.message.bytes": "2000000"}

# Topic without creation config
topic_name_no_config = "snuba-dead-letter-replays"
topic_name_no_config = "outcomes"
topic_data = get_topic(topic_name_no_config)
assert topic_data["topic_creation_config"] == {}

Expand Down
2 changes: 2 additions & 0 deletions topics/ingest-events-dlq.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/ingest-generic-metrics-dlq.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/ingest-metrics-dlq.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-generic-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-group-attributes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-querylog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-replays.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"

0 comments on commit 266f25e

Please sign in to comment.