Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix events schema #170

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: Fix events schema #170

merged 1 commit into from
Aug 2, 2023

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Jul 26, 2023

Type was being defined twice

@lynnagara lynnagara requested a review from a team as a code owner July 26, 2023 20:12
@github-actions
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.22
  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.22

latest version: 0.1.22

There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.

This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out?

@lynnagara lynnagara merged commit e2b2f4a into main Aug 2, 2023
14 of 15 checks passed
@lynnagara lynnagara deleted the events-schema-fix branch August 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants