Allow new nel event type in events topics
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
versions in use: The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
latest version: 0.1.28 There were changes to the JSON schema file, but we couldn't categorize any of This might be a gap in linting. Want to take a look at |
lynnagara
approved these changes
Sep 26, 2023
oioki
added a commit
to getsentry/relay
that referenced
this pull request
Nov 6, 2023
The first part of the NEL ([Network Error Logging](https://developer.mozilla.org/en-US/docs/Web/HTTP/Network_Error_Logging)) implementation. * Adds a new `Nel` EventType * Adds a new `Nel` protocol with minimal validation (i.e. only specific fields are captured) * Adds a new `/api/:project_id/nel/` endpoint for NEL reports ingestion * simple content type validation * splits payload into separate envelopes (a single HTTP NEL request could contain several independent reports) * `user.ip_address` field is set to the IP address of the request (real user's IP address) * An event is enriched with browser information derived from the request's `User-Agent` header Related PRs: getsentry/sentry#55135 getsentry/sentry-kafka-schemas#177 --------- Co-authored-by: Oleksandr Kylymnychenko <oleksandr@sentry.io> Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com> Co-authored-by: Jan Michael Auer <mail@jauer.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for getsentry/sentry#55135 (Network Error Logging).
No extra validation yet (I don't see any extra validation for
cspeither). This should unblock local testing etc.