Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Fix snuba-spans example #182

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 6, 2023

No description provided.

@phacops phacops requested a review from dbanda October 6, 2023 16:39
@phacops phacops requested a review from a team as a code owner October 6, 2023 16:39
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.30
  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.30
  • getsentry/relay: rust:sentry-kafka-schemas==0.2.0 (upgrade)

latest version: 0.1.30

There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.

This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out?

@phacops phacops merged commit 1f539bd into main Oct 6, 2023
13 of 14 checks passed
@phacops phacops deleted the pierre/spans-fix-snuba-spans-example branch October 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants