Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Fix types for integer and number fields #185

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 13, 2023

No description provided.

@phacops phacops requested a review from a team as a code owner October 13, 2023 11:47
@github-actions
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/relay: rust:sentry-kafka-schemas==0.2.0 (upgrade)
  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.30 (upgrade)
  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.31

latest version: 0.1.31

changes considered breaking

schemas/ingest-spans.v1.schema.json

  • {"path": ".span.exclusive_time", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
  • {"path": ".span.start_timestamp", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
  • {"path": ".span.timestamp", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    

schemas/snuba-spans.v1.schema.json

  • {"path": ".duration_ms", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
  • {"path": ".duration_ms", "change": {"RangeAdd": {"added": "maximum", "value": 4294967295.0}}}
    
  • {"path": ".exclusive_time_ms", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
  • {"path": ".organization_id", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
  • {"path": ".project_id", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
  • Restricted the type of .retention_days, as null is no longer allowed

    {"path": ".retention_days", "change": {"TypeRemove": {"removed": "null"}}}
    
  • {"path": ".start_timestamp_ms", "change": {"RangeAdd": {"added": "minimum", "value": 0.0}}}
    
benign changes

schemas/snuba-spans.v1.schema.json

  • {"path": ".exclusive_time_ms", "change": {"TypeAdd": {"added": "number"}}}
    

⚠️ This PR contains breaking changes. Normally you should avoid that and make
your consumer backwards-compatible (meaning that updated consumers can still
accept old messages). There are a few exceptions:

  • If consumers already require these invariants in practice, and you're
    just adjusting the JSON schema to reality, ignore this warning.

  • If you know what you are doing, this change could potentially be rolled out
    to producers first, but that's not a flow we support.

@phacops phacops merged commit 03d06d3 into main Oct 13, 2023
14 of 15 checks passed
@phacops phacops deleted the pierre/spans-fix-types-for-integer-fields branch October 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants