Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gauges to ingest + snuba generic metrics schema #186

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Oct 19, 2023

Schema representing the 5 expected values of a Gauge

@ayirr7 ayirr7 changed the title add gauges to snuba generic metrics schema Add gauges to snuba generic metrics schema Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.32
  • getsentry/relay: rust:sentry-kafka-schemas==0.2.0 (upgrade)
  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.32
  • getsentry/snuba: rust:sentry-kafka-schemas==0.1.32

latest version: 0.1.32

changes considered breaking

schemas/ingest-metrics.v1.schema.json

  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "count"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "last"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "max"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "min"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "sum"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "count"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "last"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "max"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "min"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "sum"}}}
    

schemas/snuba-generic-metrics.v1.schema.json

  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "count"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "last"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "max"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "min"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "sum"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "count"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "last"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "max"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "min"}}}
    
  • {"path": ".value.<anyOf:2>", "change": {"RequiredAdd": {"property": "sum"}}}
    
benign changes

schemas/ingest-metrics.v1.schema.json

  • {"path": ".value", "change": {"TypeAdd": {"added": "object"}}}
    

schemas/snuba-generic-metrics.v1.schema.json

  • {"path": ".value", "change": {"TypeAdd": {"added": "object"}}}
    

⚠️ This PR contains breaking changes. Normally you should avoid that and make
your consumer backwards-compatible (meaning that updated consumers can still
accept old messages). There are a few exceptions:

  • If consumers already require these invariants in practice, and you're
    just adjusting the JSON schema to reality, ignore this warning.

  • If you know what you are doing, this change could potentially be rolled out
    to producers first, but that's not a flow we support.

@ayirr7 ayirr7 marked this pull request as ready for review October 19, 2023 18:45
@ayirr7 ayirr7 requested a review from a team as a code owner October 19, 2023 18:45
@ayirr7 ayirr7 requested a review from lynnagara October 30, 2023 21:48
@ayirr7 ayirr7 changed the title Add gauges to snuba generic metrics schema Add gauges to ingest + snuba generic metrics schema Oct 30, 2023
@ayirr7 ayirr7 merged commit 9c8936f into main Nov 1, 2023
14 of 15 checks passed
@ayirr7 ayirr7 deleted the add-gauges branch November 1, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants