Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): add feedback as new event type #187

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

JoshFerge
Copy link
Member

  • Adds the feedback event type. See https://github.com/getsentry/team-replay/issues/222
  • We'll be leveraging the issue platform to create issues, and these feedbacks will flow in from relay on the events topic and be picked up in the ingest consumer and have issues created via issue platform, which is why we need the event type on both.

@JoshFerge JoshFerge requested a review from a team as a code owner October 24, 2023 22:49
@github-actions
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.32
  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.32
  • getsentry/snuba: rust:sentry-kafka-schemas==0.1.32

latest version: 0.1.32

There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.

This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out?

@JoshFerge
Copy link
Member Author

should be fine to roll out as this change is additive.

@@ -1087,7 +1087,8 @@
"expectstaple",
"transaction",
"nel",
"default"
"default",
"feedback"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, how come we're changing events too? Is it not just an issue platform change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedbacks are going to be a new event type in addition to new issue type.

@JoshFerge JoshFerge merged commit 22183a9 into main Oct 25, 2023
14 of 15 checks passed
@JoshFerge JoshFerge deleted the jferg/add-feedback-event-type branch October 25, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants