Embed and expose examples in Rust #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This embeds all the example data in the built Rust crate, and adds a new `examples()` method on `Schema` to expose that to consuming Rust code.
untitaker
approved these changes
Jan 5, 2024
rust/lib.rs
Outdated
| @@ -146,22 +152,28 @@ pub fn get_schema(topic: &str, version: Option<u16>) -> Result<Schema, SchemaErr | |||
| let s = serde_json::from_str(schema).map_err(|_| SchemaError::InvalidSchema)?; | |||
| let compiled_json_schema = JSONSchema::compile(&s).map_err(|_| SchemaError::InvalidSchema)?; | |||
|
|
|||
| // FIXME(swatinem): This assumes that there is only a single examples directory | |||
There was a problem hiding this comment.
there is, or am i misunderstanding what this means?
There was a problem hiding this comment.
I expanded the FIXME comment:
// FIXME(swatinem): This assumes that there is only a single `examples` entry in the definition.
// If we would want to support multiple, we would have to either merge those in code generation,
// or rather use a `fn examples() -> impl Iterator`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This embeds all the example data in the built Rust crate, and adds a new
examples()method onSchemato expose that to consuming Rust code.