Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Remove group_raw from the schema as it's not used anymore #199

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jan 8, 2024

No description provided.

@phacops phacops requested a review from a team as a code owner January 8, 2024 17:23
Copy link

github-actions bot commented Jan 8, 2024

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.38 (upgrade)
  • getsentry/snuba: pip:sentry-kafka-schemas==0.1.38 (upgrade)
  • getsentry/snuba: rust:sentry-kafka-schemas==0.1.40

latest version: 0.1.40

benign changes

schemas/snuba-spans.v1.schema.json

  • Removed a property group_raw from ``, but it is still accepted via additionalProperties=true

    {"path": "", "change": {"PropertyRemove": {"lhs_additional_properties": true, "removed": "group_raw"}}}
    

✅ This PR should be safe to roll out to consumers first. Make sure to bump
the library in the following repos first:

getsentry/snuba

...then in the other repos:

getsentry/sentry

Take a look at the README for how to release a new version of sentry-kafka-schemas.

@phacops phacops merged commit 3d9aa4b into main Jan 8, 2024
15 checks passed
@phacops phacops deleted the pierre/spans-remove-group_raw branch January 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants