-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uptime): Add request{method,headers,body} fields #330
feat(uptime): Add request{method,headers,body} fields #330
Conversation
versions in use: The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
latest version: 0.1.107 changes considered breakingschemas/uptime-configs.v1.schema.json
|
966cbec
to
9fa59ef
Compare
2d9a1af
to
8291637
Compare
"request_body": { | ||
"description": "Additional HTTP headers to send with the request", | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I'm thinking about it... should the body also just be a json dict? Mostly people are sending specific key/val params here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no I think it's very reasonable someone might want to pass xml or some other format
Adds to the uptime-configs topic schema the ability to specify method, headers, and body