feat(eap): Add EAP mutations topic #333
Conversation
CODEOWNERS
Outdated
| @@ -1,126 +1,142 @@ | |||
| # Search and storage and infra is the default owner | |||
| * @getsentry/owners-snuba @getsentry/ops | |||
There was a problem hiding this comment.
this entire file got reformatted, please revert that
There was a problem hiding this comment.
Not sure why but every time I try to save it, it reverts to reformatting it. Do you know how to fix that?
There was a problem hiding this comment.
turn off format-on-save in your editor for this file
|
@ayirr7 if it's really the bot reformatting the file, forget about it, just merge then. sorry for the noise |
| "description": "The trace ID is a unique identifier for a trace. It is a 16 byte hexadecimal string." | ||
| }, | ||
| "span_id": { | ||
| "type": "integer" |
There was a problem hiding this comment.
@untitaker Had some questions here -- I was comparing against the spans topic schema, and I think span_id is a String? I noticed a couple of other examples like this too
There was a problem hiding this comment.
you are right. please change this in the schema. it should not be an int at all, that's a mistake in the code
ayirr7
changed the title
Doing this separately so we can roll it out independently of the actual consumer: #6216 This will be rolled out after the schema is published getsentry/sentry-kafka-schemas#333
Adds the schema, topic metadata, and an example for the new Snuba eap mutations topic
Relevant to getsentry/snuba#6216