feat(protobuf) Add support for protobuf message topics #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For taskworkers (and likely other topics) in the future, we would like to put protobuf serialized messages into the topic instead of json/msgpack. Using protobufs will let us have one message schema for both kafka, rpc and application logic. In order to get access to the protobuf generated code, I've needed to expand the dependencies of this library. I thought this was the simplest to build and maintain solution.
volokluev
reviewed
Oct 30, 2024
topics/task-worker.yaml
Outdated
| # TODO(mark) protobuf support | ||
| type: json | ||
| resource: taskworker.v1.schema.json | ||
| compatibility_mode: backward |
There was a problem hiding this comment.
how does this compatibility mode actually affect functionality?
There was a problem hiding this comment.
I had interpreted this as indicating that the messages in the topic were backwards compatible. However, we have no topics with this mode right now, which makes me think it may not be complete.
We don't have any topics that are backward yet.
Our protos package isn't compatible with python 3.9. 3.9 went end of life mid 2022 and I don't think we have any applications still running on 3.9
evanh
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For taskworkers (and likely other topics) in the future, we would like to put protobuf serialized messages into the topic instead of json/msgpack. Using protobufs will let us have one message schema for both kafka, rpc and application logic.
In order to get access to the protobuf generated code, I've needed to expand the dependencies of this library. I thought this was the simplest to build and maintain solution.