tests: add test cronjob manifests for errors and delays #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: We did not have cronjob manifests that tested tasks of variable durations that either succeeded or failed.
Now:
We created new manifests to test the following cases:
cronjob-late-success: similar tocronjob-basic-successbut the task first sleeps for an interval between 0 seconds to 60 seconds. This tests how Crons registers the late checkin during exit.cronjob-maybe-error: this task either errors or succeeds with equal chancecronjob-late-maybe-error: this task also has variable duration but may either succeed or error with equal chance