feature: allow object manifest to define custom DSN #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyo
reviewed
Dec 11, 2023
tonyo
reviewed
Dec 12, 2023
tonyo
approved these changes
Dec 13, 2023
Jiahui-Zhang-20
added a commit
that referenced
this pull request
Dec 13, 2023
* allow custom dsn in manifest * fix errors of sending to wrong projects * clients inherit old options with only dsn changed * change transport mock to remove last event * refactor dsn code * fix event watcher to pass unit test * perform minor code cleanup * add flag for custom dsn * add minor changes to sentry dsn data
Jiahui-Zhang-20
added a commit
that referenced
this pull request
Dec 14, 2023
* add unit test for pod enhancer * Make aliasing more explicit * feature: allow object manifest to define custom DSN (#72) * allow custom dsn in manifest * fix errors of sending to wrong projects * clients inherit old options with only dsn changed * change transport mock to remove last event * refactor dsn code * fix event watcher to pass unit test * perform minor code cleanup * add flag for custom dsn * add minor changes to sentry dsn data * downgrade client-go version * fix dependency issues --------- Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous:
All events must be sent to a single project corresponding to the DSN specified in the environment variable.
Now:
The manifest may contain a custom DSN in the annotations so the event may be sent to a different corresponding project instead (this works with both Issues and Crons).