Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test for pod enhancer #73

Merged
merged 6 commits into from
Dec 14, 2023
Merged

test: add unit test for pod enhancer #73

merged 6 commits into from
Dec 14, 2023

Conversation

Jiahui-Zhang-20
Copy link
Contributor

Added unit test for the runPodEnhancer function to check that the expected tags and fingerprints are set for the Sentry event

tonyo
tonyo reviewed Dec 13, 2023
View reviewed changes
context.go Show resolved Hide resolved
tonyo
tonyo reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@tonyo tonyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. If you feel like it, feel free to also add Codecov to the repo, so we can get proper info on the code coverage 👍

go.mod Outdated Show resolved Hide resolved
@Jiahui-Zhang-20
feature: allow object manifest to define custom DSN (#72)
551a775 
* allow custom dsn in manifest

* fix errors of sending to wrong projects

* clients inherit old options with only dsn changed

* change transport mock to remove last event

* refactor dsn code

* fix event watcher to pass unit test

* perform minor code cleanup

* add flag for custom dsn

* add minor changes to sentry dsn data
@Jiahui-Zhang-20
Merge branch 'main' into jz-pod-enhancer-unit-tests
c13aca3
@Jiahui-Zhang-20
downgrade client-go version
3bc88b1
@Jiahui-Zhang-20
fix dependency issues
e9648b2
@Jiahui-Zhang-20 Jiahui-Zhang-20 merged commit 9086675 into master Dec 14, 2023
3 checks passed
@Jiahui-Zhang-20 Jiahui-Zhang-20 deleted the jz-pod-enhancer-unit-tests branch December 14, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyo tonyo tonyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiahui-Zhang-20 @tonyo