feature: refactor pod enhancer so all workload resource types are used #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyo
reviewed
Dec 15, 2023
tonyo
reviewed
Dec 18, 2023
tonyo
reviewed
Dec 19, 2023
tonyo
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
The pod enhancer does not consider workload resource types such as
ReplicaSetandDeployment. There were several k8s API calls for retrieving throughout the project. This makes it hard to refactor and use the indexer for caching. This is because each API call has to be specific to the object type (e.g.Pod,Job,Deployment...)Now:
The query logic is refactored with a function named
findObjectthat generically returnsmetav1.Object. The cached object is also no longer justinterface{}but insteadmetav1.Object.In order to associate a pod state change to any owning objects, we use DFS to find all owning objects (usually one) of type
metav1.Object. Then the pod enhancer calls specific owning object enhancers to add metadata to the sentry event.