Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct fingerprinting and common enhancer call #78

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

Jiahui-Zhang-20
Copy link
Contributor

Issues Addressed:

  1. If the involved object has owners, then the fingerprint now only includes the owners' kind and name so all objects with the same root owner are grouped. For example, if the involved object is a pod and it is owned by a deployment, the fingerprint will not include Pod or <pod_name> but instead Deployment and <deployment_name>.
  2. Currently, the general enhancer only supports a subset of workload resource objects (Pod, Job, CronJob, ReplicaSet, Deployment) but not others (e.g. Node, Service, StatefulSet). We now call the common enhancer on the involved object regardless of whether the general enhancer supports that object. This way, the event message can at least be enhanced if needed.

@Jiahui-Zhang-20 Jiahui-Zhang-20 changed the title fix fingerprinting and common enhancer call fix: correct fingerprinting and common enhancer call Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (ea40479) 25.59% compared to head (4f9106e) 27.19%.

Files Patch % Lines
enhancers.go 54.54% 45 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   25.59%   27.19%   +1.59%     
==========================================
  Files          22       22              
  Lines        1633     1651      +18     
==========================================
+ Hits          418      449      +31     
+ Misses       1175     1157      -18     
- Partials       40       45       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

watcher_events.go Outdated Show resolved Hide resolved
@Jiahui-Zhang-20 Jiahui-Zhang-20 merged commit 243c08f into master Dec 20, 2023
5 checks passed
@Jiahui-Zhang-20 Jiahui-Zhang-20 deleted the jz-fix-enhancers branch December 20, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants